Fix flaky activation test by polling instead of fixed delay#4283
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky activation test that was failing intermittently on Windows CI by replacing a hardcoded 4-second delay with a polling approach that checks for extension activation up to 30 seconds.
Changes:
- Replaced fixed
delay()calls with a newwaitForActivation()function that polls extension status - Implemented polling logic with 100ms intervals and 30-second timeout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
extensions/ql-vscode/test/vscode-tests/minimal-workspace/activation.test.ts
Show resolved
Hide resolved
extensions/ql-vscode/test/vscode-tests/minimal-workspace/activation.test.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/test/vscode-tests/minimal-workspace/activation.test.ts
Outdated
Show resolved
Hide resolved
ginsbach
approved these changes
Feb 2, 2026
Contributor
ginsbach
left a comment
ginsbach
left a comment
There was a problem hiding this comment.
Generally LGTM, but some of the CCR comments might be worth looking into.
The activation test was failing intermittently on Windows CI because it used a hardcoded 4-second delay after opening a .ql file to wait for the extension to activate. On slower machines, this wasn't enough time. Replace the fixed delay with a polling loop that checks ext.isActive every 100ms for up to 30 seconds. This ensures the test: - Returns quickly on fast machines - Doesn't fail prematurely on slow machines
cklin
force-pushed
the
cklin/activation-test-deflake
branch
from
067d244 to
6d15f37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The activation test was failing intermittently on Windows CI because it used a hardcoded 4-second delay after opening a .ql file to wait for the extension to activate. On slower machines, this wasn't enough time.
Replace the fixed delay with a polling loop that checks ext.isActive every 100ms for up to 30 seconds. This ensures the test: